This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Derive client retry timeouts from slot duration #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2984 +/- ##
=======================================
+ Coverage 73.6% 76.7% +3%
=======================================
Files 128 128
Lines 20466 19644 -822
=======================================
+ Hits 15071 15074 +3
+ Misses 5395 4570 -825 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2984 +/- ##
=======================================
+ Coverage 73.6% 76.7% +3%
=======================================
Files 128 128
Lines 20466 19644 -822
=======================================
+ Hits 15071 15074 +3
+ Misses 5395 4570 -825 |
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Sep 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of 8 second slots (cc: #2981) to improve some client retry logic to use SDK timing constants.
Hopefully this helps with some of the recent timing-related CI integration test failures that have been occurring since we went back to slowmo slots.